fix: bug when repositioning traffic lights in RTL mode #22132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow-up to #21781 and #22016, there is a bug when using the new
trafficLightPosition
API when the system is in RTL mode. cc @mohitsud @seshrsUsing
trafficLightPosition: {x: 1, y: 1}
:Bug:
Fixed:
Bug is due to the fact that the x-position is always calculated from the top left of the screen when using
trafficLightPosition
, but in RTL mode we should calculate the offset from the right.Checklist
npm test
passesRelease Notes
Notes: Fixed bug that occurred when using trafficLightPosition API in RTL mode